search

google / mathsteps

Step by step math solutions for everyone
https://socratic.org
Apache License 2.0
2.12k stars 275 forks source link

Refactor test to use TestUtil #99

Closed nitin42 closed 7 years ago

nitin42 commented 7 years ago

addresses #42

Refactored some tests with TestUtil.js

nitin42 commented 7 years ago

There are no issues with the syntax in current codebase. Not to argue but it can be refactored with ES6 syntax if the scope of the project broadens in the future. So that it will be more easy for the new contributors to make any changes but I doubt about the performance issues. Because it will be required to transpiled through babel. I hope one day the JavaScript community will stable. You may create an issue regarding this if you feel right 😄 .

evykassirer commented 7 years ago

thanks!

I'm open to more es6 :) but let's do that in a separate change

thanks for your patience - I added some more comments

evykassirer commented 7 years ago

can you merge from master so it's easier to see which changes are yours? right now other changes are in this pull request too.

thanks for your quick updates :D I had a lot of stuff going on this week but should be able to respond faster now.

nitin42 commented 7 years ago

Created new PR and merged from master. Bcoz I was clearing some of my forks yesterday and deleted the original fork of this repo by mistake.

evykassirer commented 7 years ago

aww that sucks

continued at #117