Add translator comment parsing

google / mdbook-i18n-helpers

Translation support for mdbook. The plugins here give you a structured way to maintain a translated book.

Apache License 2.0

127 stars 25 forks source link

Add translator comment parsing #106

Closed dyoo closed 10 months ago

dyoo commented 10 months ago

This moves the comment directive parsing to a separate module and adds two features:

Customizable prefix for the directive. It defaults to "i18", but to maintain compatibility, overridden with "mdbook-xgettext" in its current usage.
Can parse translator comments.

This is preparatory work to thread this state during message extraction.

mgeisler commented 10 months ago

This needs a little rebase before it can be tested and merged.

dyoo commented 10 months ago

Rebased and applied recommended cleanups; once it looks good to you, I'll squash the fixup commits into the branch.

dyoo commented 10 months ago

Sounds good. Please merge.

Thanks for your patience as I'm still catching up on responding to your comments. I'll try to be a bit more prompt in the future.

mgeisler commented 10 months ago

Thanks for your patience as I'm still catching up on responding to your comments. I'll try to be a bit more prompt in the future.

All good! It's your PR and you can drive it at whatever speed suits you :slightly_smiling_face: This feature is not blocking anything directly, so it's not something I'm trying to push super hard.