search

google / mdbook-i18n-helpers

Translation support for mdbook. The plugins here give you a structured way to maintain a translated book.
Apache License 2.0
127 stars 25 forks source link

Prepare `extract_messages` to return translator comments #107

Closed dyoo closed 6 months ago

dyoo commented 10 months ago

Part of #63.

mgeisler commented 10 months ago

This needs a little rebase before it can be tested and merged.

dyoo commented 10 months ago

Sounds good! I'll sync soon; I plan to do a rebase on top of dalance's work soon, since it looks like they're further along.

dyoo commented 9 months ago

I believe this is close to ready. Is there anything I've missed before I flatten the history?

mgeisler commented 8 months ago

I believe this is close to ready. Is there anything I've missed before I flatten the history?

Hey @dyoo, happy new year! Sorry for the slow reply! It would be useful if you squash the commits and rebase on top of the latest main. That should resolve the conflicts and then I can look it over.

dyoo commented 7 months ago

My deep apologies for leaving this to wither. I was sick again for the past week or two, so was unable to work on this for a very long time.

Let me page this back into my memory this week and prepare this for review once more.

mgeisler commented 7 months ago

My deep apologies for leaving this to wither. I was sick again for the past week or two, so was unable to work on this for a very long time.

No worries at all! I'm sorry to hear about that and please know that there's no stress about this.

Let me page this back into my memory this week and prepare this for review once more.

Thanks! I'm trying to limit my time working on the course to less than a day a week, so it might take me a week to get around to looking at this.

@kdarkhan, if you have more time to get into the Rust code, then this PR and feature (#63) would be a way place to look. Basically, PO files have supports for special comments and I'm thinking it could be useful for translators if we can add these comments to the Markdown files.

codecov-commenter commented 7 months ago

Codecov Report

Attention: 34 lines in your changes are missing coverage. Please review.

Comparison is base (3012f1d) 89.55% compared to head (8b772ed) 89.11%.

Files Patch % Lines
i18n-helpers/src/lib.rs 83.66% 27 Missing and 6 partials :warning:
i18n-helpers/src/normalize.rs 88.88% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #107 +/- ## ========================================== - Coverage 89.55% 89.11% -0.45% ========================================== Files 12 12 Lines 2442 2618 +176 Branches 2442 2618 +176 ========================================== + Hits 2187 2333 +146 - Misses 190 215 +25 - Partials 65 70 +5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mgeisler commented 6 months ago

I merged this now so we can start building on top of it — thanks @dyoo for sticking with it! Perhaps you can send out some small PRs with any follow up changes?