google / mdbook-i18n-helpers

Translation support for mdbook. The plugins here give you a structured way to maintain a translated book.
Apache License 2.0
126 stars 25 forks source link

Implement coverage reports using codecov #143

Closed kdarkhan closed 7 months ago

kdarkhan commented 7 months ago

cargo-llvm-cov is used for generating coverage reports.

The library supports different report types which all have their own pros and cons:

Given the above limitations, I propose using --codecov based approach which this PR implements.

I am not integrating reports provided by cargo fuzz coverage into this yet and planning to do it in a separate PR once we agree on the initial approach. cargo fuzz coverage generates an output which is closer to --lcov mentioned above. There is a hack that I think can be implemented to make it work with --codecov reports.

codecov-commenter commented 7 months ago

Welcome to Codecov :tada:

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered :open_umbrella:

mgeisler commented 7 months ago

Given the above limitations, I propose using --codecov based approach which this PR implements.

Excellent, this looks great! I completely agree that we should just use whatever format is easiest :smile: