search

google / mdbook-i18n-helpers

Translation support for mdbook. The plugins here give you a structured way to maintain a translated book.
Apache License 2.0
126 stars 25 forks source link

Fix code block token count #153

Closed dalance closed 7 months ago

dalance commented 7 months ago

This PR fixes wrong token count in code block reported at #150.

codecov-commenter commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (2acd3cd) 90.64% compared to head (4f3b869) 90.75%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #153 +/- ## ========================================== + Coverage 90.64% 90.75% +0.10% ========================================== Files 11 11 Lines 2373 2400 +27 Branches 2373 2400 +27 ========================================== + Hits 2151 2178 +27 Misses 159 159 Partials 63 63 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dalance commented 7 months ago

@kdarkhan Thank you for your review. I've fixed the comment and max_token_count logic.

kdarkhan commented 7 months ago

Thanks, looks good!