Closed zachcmadsen closed 6 months ago
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
View this failed invocation of the CLA check for more information.
For the most up to date status, view the checks section at the bottom of the pull request.
Attention: 2 lines
in your changes are missing coverage. Please review.
Comparison is base (
fba1b0a
) 90.74% compared to head (ba57994
) 90.80%.
Files | Patch % | Lines |
---|---|---|
i18n-helpers/src/xgettext.rs | 94.73% | 0 Missing and 2 partials :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thanks for contribution @zachcmadsen! Feel free to pick up the followup task https://github.com/google/mdbook-i18n-helpers/issues/171 if you want.
With rounded line numbers, it's possible for messages to have duplicate sources. This checks for duplicate sources before updating messages. An alternative approach is deduplicating sources after all the messages are added/updated. I went with the "on-the-fly" approach since it's simpler.
The check scans all of the sources for a message. If performance is a concern, we could try other ways to check for duplicates.
Fixes #154