search

google / mdbook-i18n-helpers

Translation support for mdbook. The plugins here give you a structured way to maintain a translated book.
Apache License 2.0
121 stars 25 forks source link

Upgrade pulldown-cmark to 0.10.3 #183

Closed kdarkhan closed 2 months ago

kdarkhan commented 3 months ago

The latest version of pulldown-cmark-to-cmark now supports pulldown-cmark. This should allow us to upgrade both dependencies.

Had to adjust TagEnd handling and change some types to fix the build failures.

Information on breaking changes in pulldown-cmark is available here. Not sure if I am missing anything. I hope that the tests we have are extensive enough to catch any issues.

codecov-commenter commented 3 months ago

Codecov Report

Attention: Patch coverage is 85.00000% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 90.27%. Comparing base (39823b5) to head (418eb86).

Files Patch % Lines
i18n-helpers/src/lib.rs 84.21% 0 Missing and 9 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #183 +/- ## ========================================== - Coverage 90.43% 90.27% -0.16% ========================================== Files 12 12 Lines 3010 3034 +24 Branches 3010 3034 +24 ========================================== + Hits 2722 2739 +17 Misses 207 207 - Partials 81 88 +7 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.