search

google / mdbook-i18n-helpers

Translation support for mdbook. The plugins here give you a structured way to maintain a translated book.
Apache License 2.0
121 stars 25 forks source link

Integrate to the bootstrap process of rust-lang/rust #193

Closed dalance closed 1 month ago

dalance commented 2 months ago

This PR changes the followings for https://github.com/rust-lang/rust/pull/124731:

Closes #191

codecov-commenter commented 2 months ago

Codecov Report

Attention: Patch coverage is 6.45161% with 58 lines in your changes are missing coverage. Please review.

Project coverage is 89.74%. Comparing base (2b14491) to head (b44611b).

Files Patch % Lines
i18n-helpers/src/preprocessors/gettext.rs 0.00% 50 Missing :warning:
i18n-helpers/src/bin/mdbook-gettext.rs 0.00% 8 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #193 +/- ## ========================================== - Coverage 90.27% 89.74% -0.54% ========================================== Files 12 13 +1 Lines 3034 3052 +18 Branches 3034 3052 +18 ========================================== Hits 2739 2739 - Misses 207 225 +18 Partials 88 88 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mgeisler commented 2 months ago

Hi @dalance, thanks a lot for the PR! I would like to merge it after the small conflicts are resolved.

dalance commented 2 months ago

Thank you for your review. I resolved conflict and fixed the module visibility.

mgeisler commented 1 month ago

We should make a release with this change — @kdarkhan, are there any other changes or fixes which you would like us to wait for? I think we could get #195 merged and then do the release.

kdarkhan commented 1 month ago

We should make a release with this change — @kdarkhan, are there any other changes or fixes which you would like us to wait for? I think we could get #195 merged and then do the release.

Nothing from my side. I am ok with the release with 195 merged.