search

google / mdbook-i18n-helpers

Translation support for mdbook. The plugins here give you a structured way to maintain a translated book.
Apache License 2.0
130 stars 25 forks source link

Link is not extracted at v0.3.3 #202

Closed dalance closed 3 months ago

dalance commented 3 months ago

I found an unexpected behaviour change. At v0.3.3, link doesn't seem to be extracted. The reproduce proredure is below:

#: src/index.md:3
msgid ""
"[Rust](https://www.rust-lang.org/) is a modern systems programming language "
"focusing on safety, speed, and concurrency. It accomplishes these goals by "
"being memory safe without using  garbage collection."
msgstr ""
#: src/index.md:3
msgid ""
"Rust is a modern systems programming language focusing on safety, speed, and "
"concurrency. It accomplishes these goals by being memory safe without using "
"garbage collection."
msgstr ""
dalance commented 3 months ago

67 seems to cause the change.

https://github.com/google/mdbook-i18n-helpers/commit/97f4fb5c907a7f4155af236e087634f8cfac8e6a works fine. https://github.com/google/mdbook-i18n-helpers/commit/ab7c48dd1c02527bd009984a085aec596f4fefab is broken.

dalance commented 3 months ago

@mgeisler @kdarkhan Could you check this issue and #203? This seems to be critical because generated messages.pot becomes broken.

kdarkhan commented 3 months ago

Thanks for the fix @dalance, sorry missed the notification.

I merged and will try to release a new version once I get https://github.com/google/mdbook-i18n-helpers/pull/204 approved.

kdarkhan commented 3 months ago

Just published version 0.3.4 to crates.