search

google / mdbook-i18n-helpers

Translation support for mdbook. The plugins here give you a structured way to maintain a translated book.
Apache License 2.0
121 stars 25 forks source link

Remove unnecessary strip_link #203

Closed dalance closed 1 month ago

dalance commented 1 month ago

strip_link seems to remove all links from catalog. According to the comment, it should be applied to summary only.

https://github.com/google/mdbook-i18n-helpers/blob/71b4cc5d1c0cf0db14f2c264ddccee401b8e36c6/i18n-helpers/src/xgettext.rs#L145-L149

Closes #202

codecov-commenter commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.51%. Comparing base (71b4cc5) to head (9440833).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #203 +/- ## ========================================== + Coverage 89.50% 89.51% +0.01% ========================================== Files 13 13 Lines 3135 3138 +3 Branches 3135 3138 +3 ========================================== + Hits 2806 2809 +3 Misses 236 236 Partials 93 93 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dalance commented 1 month ago

I added a link example to non-SUMMARY.md test to catch this case.