search

google / mdbook-i18n-helpers

Translation support for mdbook. The plugins here give you a structured way to maintain a translated book.
Apache License 2.0
141 stars 25 forks source link

i18n-report: utility to generate HTML reports of translation stats #209

Closed qwandor closed 4 months ago

codecov-commenter commented 4 months ago

Codecov Report

Attention: Patch coverage is 0% with 91 lines in your changes missing coverage. Please review.

Project coverage is 86.99%. Comparing base (abf8789) to head (e124035).

Files Patch % Lines
i18n-report/src/stats.rs 0.00% 65 Missing :warning:
i18n-report/src/main.rs 0.00% 26 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #209 +/- ## ========================================== - Coverage 89.51% 86.99% -2.53% ========================================== Files 13 15 +2 Lines 3138 3229 +91 Branches 3138 3229 +91 ========================================== Hits 2809 2809 - Misses 236 327 +91 Partials 93 93 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mgeisler commented 4 months ago

Hey @qwandor, this is really cool!

One idea: this binary could be it's own crate since I don't think it's dependant on mdbook like the rest of the binaries in mdbook-i18n-helpers?

That way we won't get a dependency on Tera for everybody who uses the translation infrastructure here. The crate could live as a sibling in the same workspace.

qwandor commented 4 months ago

One idea: this binary could be it's own crate since I don't think it's dependant on mdbook like the rest of the binaries in mdbook-i18n-helpers?

Done.

mgeisler commented 4 months ago

Awesome, thanks @qwandor! Would you do the honors and publish it to crates.io?

qwandor commented 4 months ago

Yep, I'm off today but I'll do that on Monday.

mgeisler commented 4 months ago

Btw, I squash-merged it since there branch had commits which fix warnings and do refactors. I hope that's okay with you! I prefer to do normal merges since it's better for both contributors and the history, but that requires contributors to force-push a clean history.