Bump mdbook-i18n-helpers version to 0.3.5

google / mdbook-i18n-helpers

Translation support for mdbook. The plugins here give you a structured way to maintain a translated book.

Apache License 2.0

141 stars 25 forks source link

Bump mdbook-i18n-helpers version to 0.3.5 #216

Closed kdarkhan closed 4 months ago

codecov-commenter commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 85.02%. Comparing base (1da250d) to head (c138d40).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #216 +/- ## ======================================= Coverage 85.02% 85.02% ======================================= Files 15 15 Lines 3398 3398 Branches 3398 3398 ======================================= Hits 2889 2889 Misses 413 413 Partials 96 96 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

teutat3s commented 4 months ago

It looks like Cargo.lock was forgotten here. After cargo build with git tag mdbook-i18n-helpers-0.3.5 checked out I see:


❯ git diff
diff --git a/Cargo.lock b/Cargo.lock
index 2014952..ef680ce 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -675,7 +675,7 @@ dependencies = [

 [[package]]
 name = "mdbook-i18n-helpers"
-version = "0.3.4"
+version = "0.3.5"
 dependencies = [
  "anyhow",
  "chrono",

kdarkhan commented 4 months ago

@teutat3s you are right. Sorry, I missed that.

I see the latest commit from github.com/google/mdbook-i18n-helpers/pull/217 updated Cargo.toml. Does the old tag break something on your side?

teutat3s commented 4 months ago

@kdarkhan Thanks for the quick response. The old tag does break the reproducible build in the PR linked above. I will update the package to use a newer commit until the next release.