Add to `install-action`

google / mdbook-i18n-helpers

Translation support for mdbook. The plugins here give you a structured way to maintain a translated book.

Apache License 2.0

127 stars 25 forks source link

Add to `install-action` #78

Open mgeisler opened 1 year ago

mgeisler commented 1 year ago

It would be cool if one could install mdbook-i18n-helpers using install-action.

miroim commented 12 months ago

Hi @mgeisler , I am interested in working on this.

According to the guide, releases are needed to generate the manifest.Would it be possible to include binaries for Windows, macOS, and Linux in future releases (https://github.com/google/mdbook-i18n-helpers/pull/79)? This would make it much easier to add mdbook-i18n-helpers to install-action.

Please let me know if I'm wrong or need some other resources.

mgeisler commented 12 months ago

Hi @miroim, nice to meet you!

Thanks for looking into this. I agree we should generate binaries as part of the release — could you look into how people normally do that?

My Rust projects have mostly been libraries so far, and there nobody asked for binaries to be released 🙂

I use https://github.com/mgeisler/rust-release-gh-action for releasing my libraries and I would like to use it here too (eventually). Right now, the action requires a lib.rs file,p but that is something which should be fixed.

miroim commented 11 months ago

Thank you for sharing your thoughts.

Typically, binaries for different platforms are generated within the CI pipeline. This ensures that the binaries are built automatically and are readily available for each release. To make sure everything works as expected, I'll first conduct tests in the forked repository before integrating any changes into the main project.

mgeisler commented 11 months ago

To make sure everything works as expected, I'll first conduct tests in the forked repository before integrating any changes into the main project.

That's the best way for this kind of thing! Then you can (force-)push as much as you want and get quick feedback!

simonsan commented 11 months ago

This is from our nightly release pipeline: https://github.com/rustic-rs/rustic_scheduler/blob/main/.github/workflows/nightly.yml https://github.com/rustic-rs/create-binary-artifact-action/blob/main/action.yml

For inspiration:

this uses a build matrix and cross-compilation
this builds our binaries ~~- compresses them with upx,~~
packages them to tar.gz
hashes them
signs them with pgp and rsign2
and then uploads them to a nightly repository

I'm currently adapting all of that for building a tag after releasing a new version.