search

google / mdbook-i18n-helpers

Translation support for mdbook. The plugins here give you a structured way to maintain a translated book.
Apache License 2.0
127 stars 25 forks source link

Fix caching of `target` dir for `fuzz` project #96

Closed kdarkhan closed 11 months ago

kdarkhan commented 11 months ago

Currently caching does not work for fuzz job which can be verified by looking at Github workflow outputs.

The main cause of the issue is the config workspaces: fuzz -> target. The fuzz target does not use a proper workspace but a separate crate. There is a pending issue discussing that.

The rust-cache action is executed in the root of the project and is not able to locate fuzz directory by workspace name.

I decided to list the directories to cache instead of relying on target dir detection which seems to work.

I also fixed the path fuzz/corpus to i18n-helpers/fuzz/corpus.

I adjusted the caching condition save-if to cache only on main builds. I think this makes sense because we don't need to cache PRs which might not get merged or get updated multiple times during review.

mgeisler commented 11 months ago

@sakex, I believe we forgot this in #86.

sakex commented 11 months ago

Oh sorry I missed this and thanks for the fix

mgeisler commented 11 months ago

Oh sorry I missed this and thanks for the fix

I only mentioned it so that we're now three people who know about the cache path :smile: