search

google / megalista

First Party data integration solution built for marketing teams to enable audience and conversion onboarding into Google Marketing products (Google Ads, Campaign Manager, Google Analytics).
Apache License 2.0
132 stars 57 forks source link

Documentation mismatch in Google Ads Customer Match Device ID schema #17

Closed xfer closed 3 years ago

xfer commented 3 years ago
According to the documentation, the expected schema for Google Ads Customer Match Device ID table is Column name Type Description Requirement
mobile_device_id STRING Mobile device Id identifier (android AdId or IOS IDFA) required

But in the source code, the field is mobileId.

def get_row_keys(self) -> List[str]:
    return ['mobileId']
astivi commented 3 years ago

Hey there xfer, thanks for raising this up!

I believe that the documentation is correct.

In the mapper code you can see that is renames que BigQuery column from mobile_device_id to the mobileId key.

astivi commented 3 years ago

Closing this up. Feel free to reopen if any questions should arise.