search

google / mentornet

Code for MentorNet: Learning Data-Driven Curriculum for Very Deep Neural Networks
Apache License 2.0
320 stars 63 forks source link

Replaced Depricated tf.contrib.deprecated.scalar_summary with tf.compat.v1.summary.scalar #7

Closed ashutosh1919 closed 5 years ago

ashutosh1919 commented 5 years ago

This is slight change in the Summary ProtoBuf. Initially the project writers have used deprecated method scalar_summary() of tf.contrib.deprecated. But since, It may be excluded in upcomming version of tensorflow. @roadjiang sir, please review this PR. Thank you for this awesome project. It helped me very much in my work. This also tends to work with Conventional Deep Neural Nets with structured data.

googlebot commented 5 years ago

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

roadjiang commented 5 years ago

Please follow the instructions below. Thanks for the change.

If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

On Thu, Jul 25, 2019 at 2:48 AM Ashutosh Hathidara notifications@github.com wrote:

This is slight change in the Summary ProtoBuf. Initially the project writers have used deprecated method scalar_summary() of tf.contrib.deprecated. But since, It may be excluded in upcomming version of tensorflow. @roadjiang https://github.com/roadjiang sir, please review this PR. Thank you for this awesome project. It helped me very much in my work. This also tends to work with Conventional Deep Neural Nets with structured data.

You can view, comment on, or merge this pull request online at:

https://github.com/google/mentornet/pull/7 Commit Summary

  • Replaced Depricated scalar_summary with new functions of tf
  • Comments on Changes

File Changes

Patch Links:

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/google/mentornet/pull/7?email_source=notifications&email_token=ADGNQMNHSTCXC7XYPLFWYQDQBFZHPA5CNFSM4IGY3Q72YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HBN4YGQ, or mute the thread https://github.com/notifications/unsubscribe-auth/ADGNQMJAZ5EEPO77UCTDLE3QBFZHPANCNFSM4IGY3Q7Q .

-- Have a good day Lu Jiang

ashutosh1919 commented 5 years ago

Thank you for merging @roadjiang . I had tried creating CLA for both email IDs associated with github account. But it has some problem. Anyway, Thanks once again.