search

google / mipnerf

Apache License 2.0
894 stars 109 forks source link

Are the signs inverted on rgb padding? #18

Closed samedii closed 2 years ago

samedii commented 2 years ago

After the sigmoid activation I noticed that you are doing this

rgb = rgb * (1 + 2 * self.rgb_padding) - self.rgb_padding

where rgb_padding = 0.001 by default.

Is this intentional or did you mean to move the range to (rgb_padding, 1 - rgb_padding)?

jonbarron commented 2 years ago

The range is intended to be (-0.001, 1.001).

samedii commented 2 years ago

Thanks for the quick response! :)