Use of sensor size in focal length calculation - Githubissues

google / mipnerf

Apache License 2.0

894 stars 109 forks source link

Use of sensor size in focal length calculation #21

Closed RohanChacko closed 2 years ago

RohanChacko commented 2 years ago

Hi,

Thanks for making the mip-NeRF codebase public. For the focal length calculation, why isn't the actual sensor size used (example 36mm for the Blender dataset) here? I believe the formula for calculating focal length from FOV uses the true sensor size. https://github.com/google/mipnerf/blob/84c969e0a623edd183b75693aed72a7e7c22902d/internal/datasets.py#L349