search

google / mipnerf

Apache License 2.0
894 stars 109 forks source link

Radii computation with and without NDC #31

Closed NagabhushanSN95 closed 2 years ago

NagabhushanSN95 commented 2 years ago

The radii computation code is different for non-ndc and ndc spaces. In particular, without ndc, radii computation uses only dx derived from directions, but when ndc is enabled, (dx+dy)/2 is used, which is derived from ndc_origins. Can you please shed some light on why it is done so?

jonbarron commented 2 years ago

I think this is an oversight on our part. I doubt it matters, they're both valid choices, and dy and dx should always be pretty similar values.

jonbarron commented 2 years ago

Please let me know if performance is very sensitive to dx vs (dx+dy)/2, that would be interesting!

NagabhushanSN95 commented 2 years ago

Okay. Thanks for the clarification. In case I test it out, I'll update here :)