search

google / mipnerf

Apache License 2.0
894 stars 109 forks source link

origins and directions issues #38

Closed haiz20060684 closed 1 year ago

haiz20060684 commented 1 year ago

hi,thanks for your exciting work.I have one question. In the code,the initialization values of directions are (x,y,1),so i think the values of origins should be (x,y,0).So,the values of directions are Xdirections=R*Xc+t,the values of origins are Xdirections-R[0:3,2].

jonbarron commented 1 year ago

Sorry, I don't understand your question.

haiz20060684 commented 1 year ago

In the paper,the distance of origin and direction is 1.In the code,the initialization image coordinate values of directions are [0.5...,0.5...,1],so the world coordinate values of directions should be RKinverseX+t,but RKinverseX.