google / mipnerf

Apache License 2.0
894 stars 109 forks source link

Use normalized direction vector or not? #43

Open qhdqhd opened 1 year ago

qhdqhd commented 1 year ago

AS you said: in https://github.com/google/mipnerf/blob/84c969e0a623edd183b75693aed72a7e7c22902d/internal/datasets.py#L193

BUT you use directions (not-norm) rather than viewdirs (unit-norm): https://github.com/google/mipnerf/blob/84c969e0a623edd183b75693aed72a7e7c22902d/internal/datasets.py#L187-L195 This is different,right? https://github.com/google/mipnerf/blob/84c969e0a623edd183b75693aed72a7e7c22902d/internal/datasets.py#L194-L200 If you use directions (not-norm) ,dx (or radii) will be the same for different pixel rays in the image . If you use viewdirs (unit-norm), dx (or radii) will be smaller for pixel rays away from image center, and bigger for pixel rays around image center.

qhdqhd commented 1 year ago

@jonbarron Help me please,thank you!