google / mipnerf

Apache License 2.0
894 stars 109 forks source link

Use of internal packages #7

Open Charles23R opened 3 years ago

Charles23R commented 3 years ago

Hi, I think you are using internal packages in scripts/summarize.ipynb.

For example: from google3.pyglib import gfile with gfile.Open(filename) as f:

jonbarron commented 3 years ago

Oops, you're right correct. Using open instead of gfile.Open should hopefully fix this, feel free to submit a PR fixing this if you like.