google / ml-compiler-opt

Infrastructure for Machine Learning Guided Optimization (MLGO) in LLVM.
Apache License 2.0
612 stars 92 forks source link

Is it not very accurate to use the size reward of the entire file as the reward for each caller-callee feature, if the file is large and has a large number of caller-callee? #325

Closed 18liumin closed 1 week ago

18liumin commented 9 months ago

def _overwrite_trajectory_reward(sequence_example: tf.train.SequenceExample, reward: float) -> tf.train.SequenceExample: """Overwrite the reward in the trace (sequence_example) with the given one.

Args: sequence_example: A tf.SequenceExample proto describing compilation trace. reward: The reward to overwrite with.

Returns: The tf.SequenceExample proto after post-processing. """ sequence_length = len( next(iter(sequence_example.feature_lists.feature_list.values())).feature)

reward_list = sequence_example.feature_lists.featurelist['reward'] for in range(sequence_length): added_feature = reward_list.feature.add() added_feature.float_list.value.append(reward)

return sequence_example

mtrofin commented 8 months ago

Notice the discount factor is 1, which should mean only one of the reward values would be picked. It's probably superfluous we set the others to be the same, and hurts readability (clearly) - makes for easier experimentation with other discount values.