google / ml-compiler-opt

Infrastructure for Machine Learning Guided Optimization (MLGO) in LLVM.
Apache License 2.0
629 stars 93 forks source link

`--compile_task` flag missing #340

Closed TIHan closed 6 months ago

TIHan commented 6 months ago

When going through the inline-demo, the Evaluate trained policy on a corpus (Optional) section, the command will not work because compile_task is missing.

FATAL Flags parsing error: Unknown command line flag 'compile_task'
boomanaiden154 commented 6 months ago

That message seems to indicate that it's not working because the compile_task flag is set, but isn't actually used anywhere? The flag was removed from generate_default_trace.py in https://github.com/google/ml-compiler-opt/commit/2ba448732b5c9aa9ed221ac70a0009293651701e and the corresponding documentation was never updated.

I've opened #341 to fix this in the documentation, but just omitting the flag should be able to fix the immediate issue.

TIHan commented 6 months ago

Ok, thank you! So just omitting the flag will work.