Add support for --flagfile to DEFINE_config_*

google / ml_collections

ML Collections is a library of Python Collections designed for ML use cases.

https://ml-collections.readthedocs.io/

Apache License 2.0

898 stars 42 forks source link

Closed froody closed 4 months ago

froody commented 7 months ago

Because config_flags inspects argv to decide when to call DEFINE_flag, --flagfiles must be evaluated/expanded before inspecting argv.

xk-huang commented 4 months ago

Hi, @marcenacp @sergomezcol. May I ask whether it is possible to merge this commit? I found it could solve https://github.com/google/ml_collections/issues/20. Thanks!

marksandler2 commented 4 months ago

Thanks, merged!