Builder names are not sanitized. - Githubissues

google / mlir-hs

Haskell bindings for MLIR

Apache License 2.0

92 stars 16 forks source link

Builder names are not sanitized. #32

Closed fuzzypixelz closed 2 years ago

fuzzypixelz commented 2 years ago

Expected Behavior

If an operation name is a Haskell keyword, the hs-generator program should sanitize it.

Actual Behavior

Keywords in builder names are not sanitized.

Steps to Reproduce the Problem

Enable the SCF dialect in the Setup.hs script, the generated module will fail to build because of the scf.if operation.

Specifications

This can be fixed by simply calling santizeName (cf. the corresponding PR)

Platform: Linux x86_64