Windows Build Hotfix - Githubissues

google / mlir-hs

Haskell bindings for MLIR

Apache License 2.0

97 stars 16 forks source link

Windows Build Hotfix #51

Closed MilesLitteral closed 7 months ago

MilesLitteral commented 9 months ago

Adds if condition where if the OS is Windows it will add some additional arguments for the current LLVM Library to be findable.

Fixes #50

[x] Tests pass
[x] Appropriate changes to README are included in PR

google-cla[bot] commented 9 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

jpienaar commented 7 months ago

Thanks, sorry missed this until now. Would it be possible to sign the CLA? (unfortunately requirement for us to review given GitHub org part of requirements).

I'll try to rebase repo to newer version of MLIR to address other failures (I'm not the recipient of failed build notifications so often miss these).

MilesLitteral commented 7 months ago

I did sign the CLA, it keeps making my username mileslitteral rather than MilesLitteral and I think it may be posing an issue: