google / mobly

E2E test framework for tests with complex environment requirements.
https://github.com/google/mobly
Apache License 2.0
647 stars 179 forks source link

Clean up dep requirements in `setup.py`. #489

Closed xpconanfan closed 6 years ago

xpconanfan commented 6 years ago

setuptools version in ubuntu dist is no longer a concern.


This change is Reviewable

winterfroststrom commented 6 years ago

apparently timeout decorator is used in monsoon.py

xpconanfan commented 6 years ago

Whaa, how come localing running unit tests didn't catch this..

winterfroststrom commented 6 years ago

because our monsoon unit test have like no coverage

winterfroststrom commented 6 years ago

also, you probably already have the dependency installed

xpconanfan commented 6 years ago

the test sets up deps from scratch every time. I think it's just we don't have coverage for monsoon...

winterfroststrom commented 6 years ago

no, I mean that the reason why running it locally passed for you was probably because a previous run of it installed the deps, where restinalling isn't actually necessary, otherwise, if it was never installed, and the reinstall logic didn't install it, I have a hard time imagining it passing

xpconanfan commented 6 years ago

Oh wait, it's the other way around...

winterfroststrom commented 6 years ago

build still broken