google / mobly

E2E test framework for tests with complex environment requirements.
https://github.com/google/mobly
Apache License 2.0
647 stars 179 forks source link

Move `register_controller` into `base_test` #492

Closed xpconanfan closed 6 years ago

xpconanfan commented 6 years ago

For historic reasons, register_controller lives under test_runner. Back then the consideration was, one day we may want to let controller objects persist across multiple test classes.

This causes multiple organizational problems and incurs complexity.

In hindsight that is a very bad idea and controller object lifecycles should be contained within each class. So it is time to push controller management into base_test.