search

google / mobly

E2E test framework for tests with complex environment requirements.
https://github.com/google/mobly
Apache License 2.0
647 stars 179 forks source link

Moving the util and updating references in tests #570

Closed stroz closed 5 years ago

stroz commented 5 years ago

The motivation is so this function can be better reused by other places.

This change is Reviewable

stroz commented 5 years ago

mobly/controllers/android_device_lib/adb.py, line 19 at r1 (raw file):

Previously, winterfroststrom wrote…
> ``` > import pipes > ``` no longer used?

Looks like it's used here in cli_cmd_to_string: return ' '.join([pipes.quote(arg) for arg in args])

stroz commented 5 years ago

mobly/controllers/android_device_lib/adb.py, line 19 at r1 (raw file):

Previously, xpconanfan (Ang Li) wrote…
But you moved that function to `utils` right? so we don't need this import in `adb` any more?

Right, I believe we can remove this from adb.

stroz commented 5 years ago

mobly/controllers/android_device_lib/adb.py, line 19 at r1 (raw file):

Previously, stroz (Tim Strother) wrote…
Right, I believe we can remove this from adb.

Done.