search

google / mobly

E2E test framework for tests with complex environment requirements.
https://github.com/google/mobly
Apache License 2.0
636 stars 177 forks source link

Initialize dicts for TestRunConfig's dict values. #651

Closed mderu closed 4 years ago

mderu commented 4 years ago

Defaults the controller and user_params to empty dictionaries in TestRunConfig.

These defaults prevent users from needing to check if they are None first, in case the runner left these values unset.

This change is Reviewable

mderu commented 4 years ago

tests/mobly/config_parser_test.py, line 14 at r1 (raw file):

# See the License for the specific language governing permissions and
# limitations under the License.

Note: the changes in each line are due to the line endings of this file being \r\n instead of \n. These are separate commits, but are in the same pull request.

mderu commented 4 years ago

tests/mobly/config_parser_test.py, line 14 at r1 (raw file):

Previously, xpconanfan (Ang Li) wrote…
why are we changing the line ending?

Because they aren't in line with the rest of the files in Mobly.

googlebot commented 4 years ago

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

googlebot commented 4 years ago

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

xpconanfan commented 4 years ago

Please sync and rebase against master HEAD, then push again (use force if necessary)

mderu commented 4 years ago

For future reference, the correct way is to upload a formatting PR to fix the large scale lint issues, then upload the code change. Will let this one in since it's a pretty small change.

Reviewable status: 0 of 2 files reviewed, all discussions resolved (waiting on @mderu)

I was trying to find a way to upload two PRs that depend on one another, but it doesn't seem possible in GitHub. In this PR, the formatting change is a separate commit from the code change. If you merge into master without squashing, these two changes will remain separate within the git history.

mderu commented 4 years ago

Fixing history, needs work.

mderu commented 4 years ago

Splitting into multiple PRs.