Closed BryanDClark closed 4 years ago
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!
and we'll verify it.
ℹ️ Googlers: Go here for more info.
Looks like CI is broken. Please fix the test.
Hm...looks like one of the checks failed because 'ConnectionRefusedError' doesn't exist in python2. Should I switch this to catch all exceptions so it's python2 compatible?
What error does it throw in py2?
socket.error, I believe: https://docs.python.org/2/library/socket.html#socket.error
I updated the except statement to catch exceptions based on the python version, seems to work for python3 (I'll let the presubmit check for python2)
Could you add a TODO to use a more specific error type after PY2 is deprecated from this code base?
Added a TODO
The ADB proxy server may be listening on 127.0.0.1 on machines where localhost resolves to [::1], which will raise a 'ConnectionRefusedError'.
This change is