search

google / mobly

E2E test framework for tests with complex environment requirements.
https://github.com/google/mobly
Apache License 2.0
628 stars 175 forks source link

Fix flake8 warning (#741) #745

Closed johnklee closed 3 years ago

johnklee commented 3 years ago

Fix flake8 warning (part2)

This change is Reviewable

xpconanfan commented 3 years ago

I think we should leave the monsoon, attenuator, and sniffer code as is. We plan to remove these code from Mobly repo as they are pretty old and not really used.

johnklee commented 3 years ago

I think we should leave the monsoon, attenuator, and sniffer code as is. We plan to remove these code from Mobly repo as they are pretty old and not really used.

Thanks for the notification. Done in below commit: https://github.com/johnklee/mobly/commit/f856b556b351d715ae6d652445a36e0fcdb4c784

johnklee commented 3 years ago

I still see files for monsoon, sniffer lib, and iperf, which should be removed from the PR.

Sorry for the inconvenience and thanks for the notification. I restore those files in below commit: https://github.com/johnklee/mobly/commit/f5aa6e1bb78dea7af17a4007c84e1bbf1b8859f6