google / mobly

E2E test framework for tests with complex environment requirements.
https://github.com/google/mobly
Apache License 2.0
628 stars 175 forks source link

Cleanup "Use of an assertion within an except block is error-prone [g-assert-in-except]" #753

Closed johnklee closed 3 years ago

johnklee commented 3 years ago

Tracker bug for cleaning up "Use of an assertion within an except block is error-prone [g-assert-in-except]":

    try:
      raise android_device.DeviceError(ad, 'Something')
    except android_device.DeviceError as e:
      self.assertEqual('<AndroidDevice|1> Something', str(e))

Should be:

    with self.assertRaisesRegex(android_device.DeviceError,
                                '<AndroidDevice|1> Something'):
      raise android_device.DeviceError(ad, 'Something')

Linting warning found:

C6903:1147:AndroidDeviceTest.test_AndroidDevice_debug_tag: Use of an assertion within an except block is error-prone [g-assert-in-except]
http://go/gpylint-faq#g-assert-in-except
C6903:1153:AndroidDeviceTest.test_AndroidDevice_debug_tag: Use of an assertion within an except block is error-prone [g-assert-in-except]
http://go/gpylint-faq#g-assert-in-except
W0703:1157:AndroidDeviceTest.test_AndroidDevice_debug_tag: Catching too general exception Exception [broad-except]
--
C6903:1158:AndroidDeviceTest.test_AndroidDevice_debug_tag: Use of an assertion within an except block is error-prone [g-assert-in-except]
http://go/gpylint-faq#g-assert-in-except