Add assertion functions for parity with unittest

google / mobly

E2E test framework for tests with complex environment requirements.

https://github.com/google/mobly

Apache License 2.0

627 stars 175 forks source link

Add assertion functions for parity with unittest #769

Closed artorl closed 2 years ago

artorl commented 2 years ago

Added assertion functions for parity with unittest (implemented as wrappers around unittest assertions).

Excluded:

assertWarns, assertLogs, and assertWarnsRegex as they are implemented with their own context managers in unittest;
assertDictContainsSubset (deprecated in unittest).

This change is

artorl commented 2 years ago

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @artorl and @xpconanfan)

_mobly/asserts.py, line 267 at r1 (raw file):_
def assert_not_is_instance(obj, cls, msg=None, extras=None):
shouldn't this be "is not instance"?

It's "assertNotIsInstance" in unittest, so I went with "assert_not_is_instance" for similarity.

https://docs.python.org/3/library/unittest.html#unittest.TestCase.assertNotIsInstance

artorl commented 2 years ago

I've made a change to fix unit tests on Python 3.6. Please approve workflow executions.