search

google / mobly

E2E test framework for tests with complex environment requirements.
https://github.com/google/mobly
Apache License 2.0
627 stars 175 forks source link

Remove the host_port and device_port attributes from ClientBase #814

Closed mhaoli closed 2 years ago

mhaoli commented 2 years ago

Part of issue #793. This change is related to the implementation of Windows client.

When implementing the Windows client, we found that we need to improve some behaviors of ClientBase.

Changed content: Removed the host_port and device_port attributes from ClientBase. Some of the deleted comments will be moved to PR #808.

Reason for the change:

  1. These 2 attributes are implementation details related to the connection. For example, the Windows client builds a new connection each time it wants to send an RPC, so it doesn't have a fixed host port.
  2. There doesn't seem to be much benefit of providing these 2 attributes in ClientBase.

This change is Reviewable