ClientBase shouldn't call "stop" if "before_starting_server" failed

google / mobly

E2E test framework for tests with complex environment requirements.

https://github.com/google/mobly

Apache License 2.0

623 stars 174 forks source link

Closed mhaoli closed 2 years ago

mhaoli commented 2 years ago

Part of #793.

Reason for change:

Keep the same logic as Android snippet client v1.
Previously I thought it was ok to call "stop" to make sure everything is cleaned. But in fact this causes different behavior from client v1, which is wrong. e.g., when "before_starting_server" fails without installing the snippet apk, "stop" will fail and raise a new error.

This change is