search

google / mobly

E2E test framework for tests with complex environment requirements.
https://github.com/google/mobly
Apache License 2.0
623 stars 174 forks source link

Fix list_fastboot_devices for other usb interfaces #859

Closed c910335 closed 1 year ago

c910335 commented 1 year ago

According to fastboot/usb_linux.cpp and fastboot/fastboot.cpp, the USB interface (the right part of fastboot devices) of a device is not always fastboot. I have seen Android Fastboot and fastbootd, but I am not sure whether there are other cases. Maybe we could just not check the interface?

This change is Reviewable

xpconanfan commented 1 year ago

Thanks for the contribution! This seems like a reasonable change. But it changes a public API so we need to put it in a major release instead of a minor.

The alternative of not checking sounds ok for the fastboot devices cmd, but we probably want to keep it for the adb devices cmd.

c910335 commented 1 year ago

I have updated it to not check only for list_fastboot_devices.

c910335 commented 1 year ago

Done.

c910335 commented 1 year ago

Done.