Closed SurajH1 closed 1 year ago
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @SurajH1)
_
mobly/controllers/android_device.py
line 119 at r1 (raw file):_for serial in list_fastboot_devices(): try: device = get_devices(ads, serial=serial)[0]
You shouldn't do this as it's instantiating some devices twice. It should be doable by simply checking the serials?
Are you referring to get_devices? get_devices is just going through the list of devices and returning which ones have the serial specified by checking the attribute of the device. This would be the same as checking serials.
I have uploaded a different solution for this https://github.com/google/mobly/pull/881
It adds the API needed for other services to check this.
Closing as this is fixed by #881
This change is![Reviewable](https://reviewable.io/review_button.svg)