Closed annahassel closed 1 year ago
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
View this failed invocation of the CLA check for more information.
For the most up to date status, view the checks section at the bottom of the pull request.
Reference Issue
Fixes #4213: for webpack issue:
Critical dependency: the request of a dependency is an expression
Before this fix, I tried
webpack.ContextReplacementPlugin
,webpack.IgnorePlugin
,import('${this.lottieLoaderUrl}')
without result.I tested it using the following code:
package.json
webpack.config.js
index.js
Console output before fix
NOTE: WARNING in ./node_modules/@google/model-viewer/lib/three-components/TextureUtils.js 57:43-71 Critical dependency: the request of a dependency is an expression.
Console output after fix (using
npm run build:dev
andnpm link
for test)NOTE: No warning.
I also tested it on real project and it is works well.