search

google / model-viewer

Easily display interactive 3D models on the web and in AR!
https://modelviewer.dev
Apache License 2.0
6.84k stars 807 forks source link

Cannot build 3.1.1 due to TS lint errors #4352

Closed designbyadrian closed 1 year ago

designbyadrian commented 1 year ago

I tried running npm install && npm run bootstrap && npm run build, but the build process is interrupted here:

src/effect-composer.ts(223,29): error TS2339: Property 'registerEffectComposer' does not exist on type 'AnnotationInterface & SceneGraphInterface & StagingInterface & EnvironmentInterface & ControlsInterface & ARInterface & LoadingInterface & AnimationInterface & ModelViewerElementBase'.
@google/model-viewer-effects: src/effect-composer.ts(234,29): error TS2339: Property 'unregisterEffectComposer' does not exist on type 'AnnotationInterface & SceneGraphInterface & StagingInterface & EnvironmentInterface & ControlsInterface & ARInterface & LoadingInterface & AnimationInterface & ModelViewerElementBase'.
lerna ERR! npm run build exited 2 in '@google/model-viewer-effects'

I try to serve the package npm run serve and visit model-viewer.dev locally, but the example pages fail with 404s, probably due to the build script not finishing what it's supposed to.

Possibly related to #4351 ?