search

google / model-viewer

Easily display interactive 3D models on the web and in AR!
https://modelviewer.dev
Apache License 2.0
6.84k stars 807 forks source link

Remove lerna #4368

Closed elalish closed 1 year ago

elalish commented 1 year ago

Fixes #4380

The main purpose of this was to fix the postinstall script that's been giving us trouble - I think the main problem is it really needs to be at the root level rather than in the model-viewer package. However, during this update I found myself in a nasty catch-22 where the bootstrap process was somehow getting the old package.json and still looking for a non-existant postinstall script. I remembered that lerna bootstrap has been deprecated for some time, so figured this might be the right time to update to npm workspaces.

Since this is related to #4260 and #4363, @Beilinson and @btopro can you review this for me?

Beilinson commented 1 year ago

I looked into the issues and this seems like the best solution to me as well. Didn't even think about the yarn issue but it totally makes sense.

tobimori commented 1 year ago

still running into this issue, would be great to get some progress here

hilyas786 commented 1 year ago

still running into this issue, would be great to get some progress here

Same using NPM, can't install can't find modules postinstall