google / model-viewer

Easily display interactive 3D models on the web and in AR!
https://modelviewer.dev
Apache License 2.0
6.84k stars 807 forks source link

model viewer js in unpkg not running location animation correctly! #4419

Closed LazZiya closed 11 months ago

LazZiya commented 1 year ago

Description

The model viewer file provided at unpkg is not playing the location animation properly! https://unpkg.com/@google/model-viewer@3.2.0/dist/model-viewer.min.js

The same version provided in google apis is working correctly! https://ajax.googleapis.com/ajax/libs/model-viewer/3.2.0/model-viewer.min.js

Live Demo

In this demo the red cube must go forward and backward through the blue one.

The first sample is using unpkg library and it is not playing location animation correctly: https://demo.ziyad.info/webar-models/anim-bug/index-b.html

The second sample based on the same model but using googleapis is working fine: https://demo.ziyad.info/webar-models/anim-bug/index-a.html

Version

Browser Affected

OS

elalish commented 1 year ago

Okay, so good news is this helped us identify and fix a google apis issue, which is that we managed to point the 3.2.0 version back at 3.1.1, hence the discrepancy with unpkg. We've updated that, so hopefully it will serve the proper version in a day or so.

The bad news is, what you're describing is a three.js regression, so now it will be broken in both places instead of one. I'm hoping it's already been fixed, so we'll get it with our next update to r155. Meanwhile, you'll probably want to pin to 3.1.1.