google / model-viewer

Easily display interactive 3D models on the web and in AR!
https://modelviewer.dev
Apache License 2.0
6.76k stars 801 forks source link

Variant normal flip #4476

Closed elalish closed 10 months ago

elalish commented 10 months ago

Fixes #4443

I don't love this solution, but anything better will require major surgery. This is related to the fact that we are still not properly handling the relatively rare situation where a single glTF material becomes several three.js materials because it is applied to meshes with different properties (e.g. tangents or none). This will still mostly work, but I'm sure there are some similar bugs lurking.