search

google / model-viewer

Easily display interactive 3D models on the web and in AR!
https://modelviewer.dev
Apache License 2.0
6.76k stars 801 forks source link

Add iridescence & anisotropy models to the test suite #4486

Closed bhouston closed 6 months ago

bhouston commented 10 months ago

Description

@echadwick-artist has created a series of new models for anisotropy and iridescence testing. We should add them to the test suite. He describes them here:

I would like to add all of the models he lists to the model-viewer test suite so that we have proper coverage in these undercovered areas.

Live Demo

None.

Version

None.

Browser Affected

None.

OS

None.

AR

None.

elalish commented 10 months ago

Yes, in fact I bet there are more models too - we haven't been keeping up with sample model updates very well. Not sure when I'll have time, but I'd welcome anyone who wants to drop a PR adding them.

bhouston commented 10 months ago

I've created a pull request here: https://github.com/google/model-viewer/pull/4493 for the anisotropy models.

elalish commented 6 months ago

I believe you already added all of these, thanks!