V-Ray CPU render fidelity tests.

[jasondavies]

Fixes #4483.

[google-cla[bot]]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[jasondavies]

Unexpectedly ran into an unknown error when leaving this to run update-screenshots:

vray: Rendering khronos-Cube...Error: Offline rendering process for V-Ray failed:
    at updateScreenshots (file:///home/jason/model-viewer/packages/render-fidelity-tools/lib/workflows/update-screenshots.js:130:31)
📋 Screenshot updates concluded
npm ERR! Lifecycle script `update-screenshots` failed with error:
npm ERR! Error: command failed
npm ERR!   in workspace: @google/model-viewer-render-fidelity-tools@0.0.1
npm ERR!   at location: /home/jason/model-viewer/packages/render-fidelity-tools

It's a shame there wasn't more information provided.

[jasondavies]

Unclear exactly why I encountered two seemingly random failures during V-Ray execution, with no errors. Not sure if error logging could be improved (it seems fine on the model-viewer side at first glance).

[jasondavies]

OK, looks like the reason for the two failures was recorded in my syslog (redacted):

Sep 29 20:15:19 XXX kernel: [ 2781.311809] python[6805]: segfault at 0 ip XXX sp XXX error 4 in libcgauth.so[XXX]
...
Sep 29 21:48:58 XXX kernel: [ 8400.248403] python[11779]: segfault at 0 ip XXX sp XXX error 4 in libcgauth.so[XXX]

Seems like a V-Ray bug. I'm using appsdk-linux_qt5-release-vray_v6.10.07-20230426.

Edit: reported the issue here: ChaosGroup/vray_gltf#7

[jasondavies]

I've added ACES filmic tone mapping now (applied to the raw image which should be linear).

[jasondavies]

Looks like a width/height swap bug in my array handling code. Re-rendering goldens now.

[jasondavies]

Camera issues fixed.

[jasondavies]

Looks like the following scenarios have obvious issues:

• Sponza (looks far too dark)
• Fox (totally blank; maybe not supported at all - like Stellar?)
• RecursiveSkeletons (though Filament looks the same)
• TextureLinearInterpolationTest
• BoxVertexColors
• SimpleMorph
• TextureSettingsTest
• TriangleWithoutIndices

Edit: fixed scenarios that have renderSkybox=true

[jasondavies]

Implemented renderSkybox support. I think this is ready for review.

[jasondavies]

I deliberately separated the third-party V-Ray code into a separate commit and marked as "submitted on behalf of a third-party" to comply with Google's CLA, but it looks like you squashed everything into one commit. I guess it's too late to change this now, but just noting this for posterity. It was also more helpful to be able to see which changes I made to the original vray_gltf in the second commit.

[elalish]

Thanks! Your separate commits will continue to live on in this PR, which is the easiest way to view them anyway, so no harm done.