google / model-viewer

Easily display interactive 3D models on the web and in AR!
https://modelviewer.dev
Apache License 2.0
6.76k stars 801 forks source link

Editor open graph metadata #4527

Closed Technickel-Dev closed 9 months ago

Technickel-Dev commented 9 months ago

Fixes #3151. By adding a og:title and og:description, the URL unfurl looks slicker! As a note, Discord seems to filter out < and > characters and the < and > characters screw with linting. The solution I found was to use Small Less-Than Sign and Small Greater-Than Sign unicode characters which convey the same meaning but don't screw with other systems.

Confirmed the changes worked and all tests passed. See the following examples from discord: Before: image

After: image

Please let me know if any changes need to be made and I will happily make them, especially on the copy side of things as I did my best to encapsulate the essence of the module.

I am participating in Hacktoberfest and would love to have this PR count towards my total. No biggie if you can't but adding a "hacktoberfest-accepted" label to the PR would make it count for me!