search

google / model-viewer

Easily display interactive 3D models on the web and in AR!
https://modelviewer.dev
Apache License 2.0
6.76k stars 801 forks source link

Enable transparencyAsCoverage in Babylon Viewer #4531

Closed bghgary closed 9 months ago

bghgary commented 9 months ago

Reference Issue

See https://github.com/KhronosGroup/glTF-Sample-Assets/pull/34#issuecomment-1775665652

google-cla[bot] commented 9 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

elalish commented 9 months ago

Thank you! Is it working? You may want to update the babylon.js version while you're at it; it's probably quite out of date.

bghgary commented 9 months ago

No idea. I am not having luck getting it to run locally. I was hoping the CI can run it instead.

bghgary commented 9 months ago

@elalish I am unable to get the cla/google to pass since I only use the users.noreply.github.com email in my commits which doesn't work apparently. Maybe you can take it further?

EDIT: Never mind. It works. I just need to rescan.

bghgary commented 9 months ago

I don't know what full_test_run is and why it's waiting.

You may want to update the babylon.js version while you're at it; it's probably quite out of date.

Maybe as a separate PR to limit the changes.

elalish commented 9 months ago

Oh, don't worry about full_test_run - you're not changing anything in that code anyway. I need to update our CI for contributors. And it looks like @bhouston updated Babylon in #4535, so we should be good.

elalish commented 9 months ago

So, our CI does't actually run any renderers besides <model-viewer>. Let's let a few more of @bhouston's PRs land and that should make it easier for you to update goldens.

bghgary commented 9 months ago

that should make it easier for you to update goldens.

Hmm, I don't see any information on this, so I have no idea what you are talking about.

elalish commented 9 months ago

4542

bghgary commented 9 months ago

Ok, just tell me what I need to do. I can't even get the npm run test to work locally.

elalish commented 9 months ago

Okay, if your dev environment isn't working then I'll assume you know how to write Babylon code like this blindly. I'll go ahead and merge it. If @bhouston has any trouble making babylon goldens, he can ping you here or there.

bghgary commented 9 months ago

I would definitely prefer for it to work, but let me know if something goes wrong with this change.