google / model-viewer

Easily display interactive 3D models on the web and in AR!
https://modelviewer.dev
Apache License 2.0
6.71k stars 799 forks source link

Update render-fidelity "update-screenshots" CLI to have more options. #4536

Closed bhouston closed 6 months ago

bhouston commented 8 months ago

Description

We need better CLI options for the update-screenshot CLI tool.

Specifically I would like to see:

Something like:

% npm run update-screenshots --renderer=filament --renderer=model-viewer --scenario=anisotropy --headless=true --parallel=true

Or something like this:

% npx update-screenshots -r filament -r model-viewer -s anisotropy -h -p

I was thinking of using commander for the CLI parsing as it is sort of industry standard.

elalish commented 8 months ago

Agreed, that would be a fantastic update!

elalish commented 6 months ago

Fixed by #4542, thanks!