Even more tests for render-fidelity test suite

google / model-viewer

Easily display interactive 3D models on the web and in AR!

https://modelviewer.dev

Apache License 2.0

6.71k stars 799 forks source link

Even more tests for render-fidelity test suite #4537

Closed bhouston closed 8 months ago

bhouston commented 8 months ago

In this PR I add the following glTF files to the test suite along with Goldens for filament, Babylon and model-viewer:

khronos-ClearCoatCarPaint
khronos-ClearCoatWicker
khronos-GlassHurricaneCandleHolder
khronos-GlassVaseFlowers
khronos-NegativeScaleTest

This builds upon my other PR here (https://github.com/google/model-viewer/pull/4535), so there is additional changes here, but if the other PR is merged then this PR becomes I think a single change.

bhouston commented 8 months ago

I'm curious why the CI is having trouble - perhaps the anisotropy renders are extra sensitive to GPU rounding differences?

For now I am removing the problematic tests to get the good stuff merged in, and we can revisit the problematic stuff later.

bhouston commented 8 months ago

Closing as I've merged this branch into this other related PR: https://github.com/google/model-viewer/pull/4535